Remove double / when requesting index.txt

[tschmidtb51]

Currently, the GET request looks like:

https://domain.example/.well-known/csaf//index.txt
https://domain.example/.well-known/csaf//changes.csv

We should remove one / to avoid redirects.

[s-l-teichmann]

My idea is to use https://pkg.go.dev/net/[email protected]#URL.JoinPath for this.
(As it will come with Go 1.19 we should have a back-ported version hidden behind a build tag)

[tschmidtb51]

My idea is to use https://pkg.go.dev/net/[email protected]#URL.JoinPath for this.

In general, I like the idea. Nevertheless, I guess we can do the short term fix (see #224).

[tschmidtb51]

(As it will come with Go 1.19 we should have a back-ported version hidden behind a build tag)

Did you mean back-porting it into this project? 🤔 Wouldn't be my first choice... What about making 1.19 mandatory? (When was it released?)

[s-l-teichmann]

Go 1.19 is not release, yet. So its not a good idea to make it mandatory.
PR #226 copies the relevant parts from the Go 1.19 source into our source (BSD licensed).
A build tag ensures that this implementation is only used when compiled with Go versions below 1.19.
In the 1.19+ case the version from the stdlib ist taken.
We can remove this conditional compilation when 1.19 is stable.

[s-l-teichmann]

Background why I would go this way is that we are joining URL path in other contexts, too. Issue #158 is another suspicious case where a simple string concat of URL strings leads to bad results.

[Fadiabb]

Hint: I've used the short term fix in the #176. Maybe its time to check if we close or merge this one.