Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets #37

Closed
jmank88 opened this issue Feb 26, 2019 · 2 comments
Closed

WebSockets #37

jmank88 opened this issue Feb 26, 2019 · 2 comments
Assignees
@jmank88 @r-gochain

Comments

@jmank88
Copy link
Contributor

jmank88 commented Feb 26, 2019

We should explore what is required to support WebSocket connections, because they allow for more features than HTTP.
jmank88 referenced this issue in gochain-io/go-post Feb 26, 2019
@treeder
Updating walkthrough...
fa1e25a
@jmank88 jmank88 self-assigned this Feb 26, 2019
@jmank88
Copy link
Contributor Author

jmank88 commented Mar 7, 2019

Maybe relevant: As of go 1.12,

The ReverseProxy now automatically proxies WebSocket requests.

https://tip.golang.org/doc/go1.12#net/http/httputil

@treeder
Copy link
Contributor

treeder commented Aug 10, 2021

We need to do this now for MEW: https://mobile.twitter.com/myetherwallet/status/1417410240220336131

@jmank88 could you try to get this working?

@treeder treeder mentioned this issue Aug 10, 2021
Open
r-gochain added a commit that referenced this issue Aug 20, 2021
@r-gochain
WebSockets #37
ba615d0
@r-gochain r-gochain mentioned this issue Aug 20, 2021
Merged
jmank88 added a commit that referenced this issue Aug 23, 2021
@r-gochain @jmank88
WebSockets #37 (#64)
011eed2 
* WebSockets #37

* copy context to a goroutine

* circleci: newer google-cloud-sdk

Co-authored-by: jmank88 <[email protected]>
@jmank88 jmank88 closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmank88 jmank88

@r-gochain r-gochain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@treeder @jmank88 @r-gochain