Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string representation of MappingNode in flow style #623

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

semihbkgr
Copy link
Contributor

@semihbkgr semihbkgr commented Jan 18, 2025

fixes #622

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.52%. Comparing base (c331468) to head (35fc253).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   77.25%   77.52%   +0.26%     
==========================================
  Files          22       22              
  Lines        7914     7831      -83     
==========================================
- Hits         6114     6071      -43     
+ Misses       1378     1347      -31     
+ Partials      422      413       -9     

@goccy
Copy link
Owner

goccy commented Feb 3, 2025

Please add the test case to parser/parser_test.go

@goccy goccy added the reviewed label Feb 3, 2025
@goccy
Copy link
Owner

goccy commented Feb 11, 2025

@semihbkgr Sorry, but the indentation got messed up when resolving the conflict. Could you fix just that? Everything else LGTM.

@goccy goccy merged commit 3992548 into goccy:master Feb 12, 2025
20 checks passed
@goccy
Copy link
Owner

goccy commented Feb 12, 2025

Thank you for your contribution !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect string representation of MappingNode in flow style
3 participants