Fix code format #594
Fix code format #594
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
==========================================
- Coverage 77.43% 77.35% -0.08%
==========================================
Files 21 21
Lines 7772 7829 +57
==========================================
+ Hits 6018 6056 +38
- Misses 1342 1354 +12
- Partials 412 419 +7 |
lexer/lexer_test.go
Outdated
| @@ -2528,7 +2528,7 @@ s: >-3 | |||
| CharacterType: token.CharacterTypeIndicator, | |||
| Indicator: token.BlockScalarIndicator, | |||
| Value: "|", | |||
| Origin: "\n| ", //nolint:gci,gofmt | |||
| Origin: "\n| ", //nolint:gci,gofmt | |||
There was a problem hiding this comment.
My gofmt ( maybe gofmt built by Go 1.22.8 ) changes to the current state, so I don't accept this changes 🤔
I think it's a difference depending on the version of gofmt.
There was a problem hiding this comment.
No, it wasn't. I think it was probably due to goimports. I'll look into it a bit more.
There was a problem hiding this comment.
Sorry, the problem was that my goimports were very old. I updated it and the problem was solved 😄
There was a problem hiding this comment.
Please remove //nolint:gci,gofmt comment 🙏
There was a problem hiding this comment.
Thank you for the review! Fixed it! 🙏
SSIA.
Before submitting your PR, please confirm the following.