Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment parsing with null value #388

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix comment parsing with null value #388

merged 1 commit into from
Sep 14, 2023

Conversation

goccy
Copy link
Owner

@goccy goccy commented Sep 14, 2023

SSIA

@goccy goccy force-pushed the fix-comment-parsing branch from 8fae396 to 416f5ed Compare September 14, 2023 03:11
@goccy goccy force-pushed the fix-comment-parsing branch from 416f5ed to f18aa87 Compare September 14, 2023 03:22
@codecov-commenter
Copy link

Codecov Report

Merging #388 (f18aa87) into master (f5c5711) will increase coverage by 0.26%.
The diff coverage is 90.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   75.66%   75.92%   +0.26%     
==========================================
  Files          13       13              
  Lines        4652     4678      +26     
==========================================
+ Hits         3520     3552      +32     
+ Misses        873      867       -6     
  Partials      259      259              

@goccy goccy merged commit 264dc0f into master Sep 14, 2023
17 checks passed
@goccy goccy deleted the fix-comment-parsing branch September 14, 2023 03:25
renovate bot referenced this pull request in anoriqq/qpm Sep 14, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/goccy/go-yaml](https://togithub.com/goccy/go-yaml) |
require | patch | `v1.11.0` -> `v1.11.1` |

---

### Release Notes

<details>
<summary>goccy/go-yaml (github.com/goccy/go-yaml)</summary>

###
[`v1.11.1`](https://togithub.com/goccy/go-yaml/releases/tag/v1.11.1):
1.11.1

[Compare
Source](https://togithub.com/goccy/go-yaml/compare/v1.11.0...v1.11.1)

#### What's Changed

- Handle `\r` in a double-quoted string the same as `\n` by
[@&#8203;k1LoW](https://togithub.com/k1LoW) in
[https://github.com/goccy/go-yaml/pull/372](https://togithub.com/goccy/go-yaml/pull/372)
- chore: replace loop with n.Values = append(n.Values, target.Values...)
by [@&#8203;testwill](https://togithub.com/testwill) in
[https://github.com/goccy/go-yaml/pull/380](https://togithub.com/goccy/go-yaml/pull/380)
- fix: skip encoding an inline field if it is null by
[@&#8203;zoncoen](https://togithub.com/zoncoen) in
[https://github.com/goccy/go-yaml/pull/386](https://togithub.com/goccy/go-yaml/pull/386)
- Fix comment parsing with null value by
[@&#8203;goccy](https://togithub.com/goccy) in
[https://github.com/goccy/go-yaml/pull/388](https://togithub.com/goccy/go-yaml/pull/388)

#### New Contributors

- [@&#8203;testwill](https://togithub.com/testwill) made their first
contribution in
[https://github.com/goccy/go-yaml/pull/380](https://togithub.com/goccy/go-yaml/pull/380)

**Full Changelog**:
goccy/go-yaml@v1.11.0...v1.11.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/anoriqq/qpm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants