Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle of space at start or last #376

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Fix handle of space at start or last #376

merged 3 commits into from
Sep 14, 2023

Conversation

ozraru
Copy link
Contributor

@ozraru ozraru commented Jul 3, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #376 (7a9ece1) into master (42fb764) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   75.61%   75.61%           
=======================================
  Files          13       13           
  Lines        4650     4650           
=======================================
  Hits         3516     3516           
  Misses        874      874           
  Partials      260      260           

@ozraru
Copy link
Contributor Author

ozraru commented Aug 2, 2023

@goccy Could you review, please?

@goccy
Copy link
Owner

goccy commented Aug 2, 2023

@ozraru Basically, the spaces before and after are automatically removed and converted to tokens, so please add specific use cases to the test cases (e.g. encode_test.go and decode_test.go )

@ozraru
Copy link
Contributor Author

ozraru commented Aug 2, 2023

@goccy done

@goccy goccy merged commit 680ea24 into goccy:master Sep 14, 2023
@goccy
Copy link
Owner

goccy commented Sep 14, 2023

LGTM

renovate bot referenced this pull request in anoriqq/qpm Sep 15, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/goccy/go-yaml](https://togithub.com/goccy/go-yaml) |
require | patch | `v1.11.1` -> `v1.11.2` |

---

### Release Notes

<details>
<summary>goccy/go-yaml (github.com/goccy/go-yaml)</summary>

###
[`v1.11.2`](https://togithub.com/goccy/go-yaml/releases/tag/v1.11.2):
1.11.2

[Compare
Source](https://togithub.com/goccy/go-yaml/compare/v1.11.1...v1.11.2)

#### What's Changed

- Fix handle of space at start or last by
[@&#8203;ozraru](https://togithub.com/ozraru) in
[https://github.com/goccy/go-yaml/pull/376](https://togithub.com/goccy/go-yaml/pull/376)
- Fix quoted comments by
[@&#8203;WillAbides](https://togithub.com/WillAbides) in
[https://github.com/goccy/go-yaml/pull/370](https://togithub.com/goccy/go-yaml/pull/370)
- Fix sequence with comment by
[@&#8203;goccy](https://togithub.com/goccy) in
[https://github.com/goccy/go-yaml/pull/390](https://togithub.com/goccy/go-yaml/pull/390)
- bump actions/checkout v4 by
[@&#8203;shogo82148](https://togithub.com/shogo82148) in
[https://github.com/goccy/go-yaml/pull/391](https://togithub.com/goccy/go-yaml/pull/391)
- add Go 1.21 to the build matrix by
[@&#8203;shogo82148](https://togithub.com/shogo82148) in
[https://github.com/goccy/go-yaml/pull/392](https://togithub.com/goccy/go-yaml/pull/392)
- apply go fmt with Go 1.21 by
[@&#8203;shogo82148](https://togithub.com/shogo82148) in
[https://github.com/goccy/go-yaml/pull/394](https://togithub.com/goccy/go-yaml/pull/394)
- bump actions/setup-go v4 by
[@&#8203;shogo82148](https://togithub.com/shogo82148) in
[https://github.com/goccy/go-yaml/pull/393](https://togithub.com/goccy/go-yaml/pull/393)

#### New Contributors

- [@&#8203;WillAbides](https://togithub.com/WillAbides) made their first
contribution in
[https://github.com/goccy/go-yaml/pull/370](https://togithub.com/goccy/go-yaml/pull/370)
- [@&#8203;shogo82148](https://togithub.com/shogo82148) made their first
contribution in
[https://github.com/goccy/go-yaml/pull/391](https://togithub.com/goccy/go-yaml/pull/391)

**Full Changelog**:
goccy/go-yaml@v1.11.1...v1.11.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/anoriqq/qpm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants