Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, trying to unmarshall invalid yaml (with unknown aliases) using custom unmarshallers lead to a panic.
See: https://go.dev/play/p/3DT9zna3Mft
This is due to decode:resolveAlias (resolveAlias) method which could not handle errors, and its AliasNode switch case (
go-yaml/decode.go
Line 293 in ecececd
anchorNodeMap
before returning a node.If an alias is unknown, decode:resolveAlias returns nil, breaking all subsequents handlings.
This pr introduce errors handling in resolveAlias, and its related methods unmarshalableDocument & unmarshalableText. It also checks that an alias is present in the anchorNodeMap an returns error if not.