Added methods to remove states and transitions from state machines. #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benk-gc
force-pushed
the
benk/delete-methods-for-statemachine
branch
from
d3518d1 to
f6968be
Compare
Historically, when a state machine uses a template and wants to remove a state or transition it will just set a guard that always returns false. This isn't a particularly neat solution since the states and transitions still exist on the state machine, and can make inspecting the internals of the state machine return misleading information. This change adds explicit methods to allow a state machine to delete states or transitions. When a state is deleted, all related transitions and callbacks will also be cleaned up as appropriate.
benk-gc
force-pushed
the
benk/delete-methods-for-statemachine
branch
from
f6968be to
42379b1
Compare
thom-oman
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, when a state machine uses a template and wants to remove a
state or transition it will just set a guard that always returns false.
This isn't a particularly neat solution since the states and transitions
still exist on the state machine, and can make inspecting the internals
of the state machine return misleading information.
This change adds explicit methods to allow a state machine to delete
states or transitions. When a state is deleted, all related transitions
and callbacks will also be cleaned up as appropriate.