Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily enable mysql gaplock protection #402

Merged
merged 1 commit into from
May 15, 2020
Merged

Lazily enable mysql gaplock protection #402

merged 1 commit into from
May 15, 2020

Conversation

thom-oman
Copy link
Contributor

Fix for #401

@thom-oman thom-oman requested a review from lawrencejones May 15, 2020 09:19
lawrencejones
lawrencejones approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@lawrencejones lawrencejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fixes our issue, according to our tests. :shipit:

@lawrencejones lawrencejones merged commit c11e039 into master May 15, 2020
@lawrencejones lawrencejones deleted the thom/lazily_configure_gaplock_prevention branch May 15, 2020 09:32
dylan-hoefsloot pushed a commit to dylan-hoefsloot/statesman that referenced this pull request Jan 11, 2024
@thom-oman @dylan-hoefsloot
Lazily enable mysql gaplock protection (gocardless#402)
820835e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawrencejones lawrencejones lawrencejones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thom-oman @lawrencejones