Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single-line string for query SQL #381

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Use single-line string for query SQL #381

merged 2 commits into from
Dec 18, 2019

Conversation

nickcampbell18
Copy link
Contributor

No description provided.

Just a cosmetic thing, we don't need to send newlines and whitespace
along with our SQL queries. We can achieve a similar effect using one
string split over multiple lines, which doesn't need `squish`ing at the
other side.
@nickcampbell18 nickcampbell18 changed the title Two small SQL query improvements Use single-line string for query SQL Dec 13, 2019
@nickcampbell18 nickcampbell18 marked this pull request as ready for review December 13, 2019 18:34
Copy link
Contributor

@danwakefield danwakefield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to have cleaner logs. Minor over patch release? since we kind of expose this to users currently.

@nickcampbell18 nickcampbell18 merged commit 375a96e into master Dec 18, 2019
@nickcampbell18 nickcampbell18 deleted the queries branch December 18, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants