Switch from WEBrick to Puma

[tschafer-gc]

WEBrick appears to be approaching EOL and is being removed from Rackup, as mentioned here. This is causing issues with a number of services as discussed here. By switching to Puma we can solve this issue while also still supporting both Rack 2 and 3.

[stephenbinns]

Looks good but can we update the smoke test so it runs both Rack 2 and 3 - https://github.com/gocardless/que/blob/master/.github/workflows/tests.yml#L22-L57

[tschafer-gc]

Looks good but can we update the smoke test so it runs both Rack 2 and 3 - https://github.com/gocardless/que/blob/master/.github/workflows/tests.yml#L22-L57

@stephenbinns I've just updated the smoke tests - does that look okay? My implementation feels a bit hacky but I'm not sure of a better way to ensure it uses both Rack versions

[stephenbinns]

Looks good but can we update the smoke test so it runs both Rack 2 and 3 - https://github.com/gocardless/que/blob/master/.github/workflows/tests.yml#L22-L57

@stephenbinns I've just updated the smoke tests - does that look okay? My implementation feels a bit hacky but I'm not sure of a better way to ensure it uses both Rack versions

Makes sense, as for making it a bit less hacky you should be able to put a conditional in the Gemfile to achieve the same result

if ENV['RACK_VERSION'] == '2.0'
  gem "rack", "~> 2.0"
else
  gem "rack", "~> 3.0"
end

And then pass the context in the env for the github action

    env:
      RACK_VERSION: "${{ matrix.rack-version }}"

[ZimbiX]

Versions can be compared using: https://stackoverflow.com/a/3064161

[tschafer-gc]

Good point, updated - thanks!