Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rubocop-rails #93

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Include rubocop-rails #93

merged 2 commits into from
Feb 9, 2022

Conversation

JoeSouthan
Copy link
Contributor

We currently import these definitions separately for each rails project, leading to inconsistent cop usage per service

@JoeSouthan JoeSouthan force-pushed the joesouthan/rails-cops branch from 0a0736a to 2996c32 Compare February 8, 2022 15:53
@JoeSouthan JoeSouthan merged commit e543f35 into master Feb 9, 2022
@JoeSouthan JoeSouthan deleted the joesouthan/rails-cops branch February 9, 2022 16:43
@ivgiuliani
Copy link
Contributor

Sadly this is now broken in all the projects that don't require rails (e.g. que-ui) :(

@JoeSouthan
Copy link
Contributor Author

@ivgiuliani I've split out the cops into a separate file: #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants