Make name optional #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeSouthan
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Hi @ineu, thanks for fixing this up and adding some spec! 🎉
Just one minor change in the readme but this is generally good to go 👍
| @@ -55,7 +55,7 @@ Get started with business by creating an instance of the calendar class, that ac | |||
| ```ruby | |||
| calendar = Business::Calendar.new( | |||
| working_days: %w( mon tue wed thu fri ), | |||
There was a problem hiding this comment.
Think it might be good to add the name arg here as well
|
Thanks for this, this will be released shortly |
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 2.2.0. The
nameargument must not be mandatory, as it breaks the existing code which is not expected from the minor version.