Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for panics when humanize called on whitespace #75

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

khayyamsaleem
Copy link
Contributor

What is being done in this PR?

Fixed #74

What are the main choices made to get to this solution?

Determine if it is a whitespace string with strings.TrimSpace, and if so, return the unmodified input string

What was discovered while working on it? (Optional)

it panics (but not anymore)

List the manual test cases you've covered before sending this PR:

Ran go test -v ./..., using all the tests supplied in issue #74

Copy link
Member

@paganotoni paganotoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paganotoni paganotoni merged commit cbe6b82 into gobuffalo:main Sep 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Panic (index out of range) when humanizing whitespace
2 participants