Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support of exact numeric data values #57

Merged

Conversation

tufanbarisyildirim
Copy link
Contributor

floating point types (float, double) and fixed point types (numeric, decimal) are different in mysql. changed translator to support other non mentioned types and return what we type in .fizz instead of returning FLOAT everytime.

@tufanbarisyildirim tufanbarisyildirim requested a review from a team as a code owner August 17, 2019 14:19
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

translators/mysql.go Outdated Show resolved Hide resolved
translators/mysql.go Outdated Show resolved Hide resolved
@tufanbarisyildirim
Copy link
Contributor Author

@stanislas-m

@stanislas-m stanislas-m self-requested a review November 9, 2019 20:06
@stanislas-m stanislas-m force-pushed the mysql-fixed-point-types branch from 44ef1b0 to 812c127 Compare February 20, 2020 08:11
@stanislas-m
Copy link
Member

Sorry for the delay and thanks!

@stanislas-m stanislas-m merged commit 6cf0294 into gobuffalo:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants