Skip to content

Commit

Permalink
chore(BREAKING CHANGES): Parser now uses Board.
Browse files Browse the repository at this point in the history
Fix #3
Fix #4

The Board returned now corresponds to a Board
from gobstones-core package, wich has multiple
method that allow easy handling of the elements.

BREAKING CHANGES
  • Loading branch information
alanrodas committed Feb 12, 2021
1 parent d85f2eb commit a3595b0
Show file tree
Hide file tree
Showing 80 changed files with 22,366 additions and 6,718 deletions.
15 changes: 1 addition & 14 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ module.exports = {
"@typescript-eslint/no-inferrable-types": "off",
"@typescript-eslint/no-namespace": "off",
"@typescript-eslint/no-parameter-properties": "off",
"@typescript-eslint/no-shadow": ["error"],
"@typescript-eslint/no-unused-vars": ["error", {
"vars": "all",
"args": "none",
Expand Down Expand Up @@ -123,12 +124,6 @@ module.exports = {
"no-return-assign": "error",
"no-return-await": "error",
"no-self-compare": "error",
"no-shadow": [
"error",
{
"hoist": "all"
}
],
"no-throw-literal": "error",
"no-undef-init": "error",
"no-underscore-dangle": "error",
Expand All @@ -149,14 +144,6 @@ module.exports = {
],
"radix": "error",
"require-await": "error",
"space-before-function-paren": [
"error",
{
"anonymous": "never",
"asyncArrow": "always",
"named": "never"
}
],
"spaced-comment": "error",
"use-isnan": "error",
"valid-typeof": "error",
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ about: Create a report to help us improve

---

Before opening a new issue, please take a moment to review our [**community guidelines**](https://github.com/gobstones/gobstones-gbb-parser/blob/master/CONTRIBUTING.md) to make the contribution process easy and effective for everyone involved.
Before opening a new issue, please take a moment to review our [**community guidelines**](https://dev.gobstones.org/contribution-guidelines) to make the contribution process easy and effective for everyone involved.

## Description
A clear and concise description of what the bug is.
Expand All @@ -20,5 +20,5 @@ A clear and concise description of what you expected to happen.

## Versions

- Gobstones GBB Parser:
- Node/NPM:
- Library Version:
- Node/NPM Version:
10 changes: 5 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Gobstones Authentication Server
## Gobstones

Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/gobstones/gobstones-gbb-parser/blob/master/CONTRIBUTING.md)
Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://dev.gobstones.org/contribution-guidelines)
to make the process easy and effective for everyone involved.

**Please open an issue** before embarking on any significant pull request,
Expand All @@ -10,8 +10,8 @@ merged into the project.

Before opening a pull request, please ensure:

- [ ] You have followed our [**contributing guidelines**](https://github.com/gobstones/gobstones-gbb-parser/blob/master/CONTRIBUTING.md)
- [ ] Double-check your branch is based on `dev` and targets `dev`
- [ ] You have followed our [**contributing guidelines**](https://dev.gobstones.org/contribution-guidelines)
- [ ] Double-check your branch is based on `main` and targets `main`
- [ ] Pull request has tests (we are going for 100% coverage!)
- [ ] Code is well-commented, linted and follows project conventions
- [ ] Documentation is updated (if necessary)
Expand All @@ -21,4 +21,4 @@ Before opening a pull request, please ensure:
Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

**IMPORTANT**: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the [MIT License](https://github.com/gobstones/gobstones-gbb-parser/blob/master/LICENSE.md).
owners to license your work under the terms of the [MIT License](https://dev.gobstones.org/licence).
26 changes: 26 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: build-on-commit
on:
push:
branches:
- main
pull_request:
branches:
- main
jobs:
test:
name: Run tests
runs-on: ubuntu-latest
strategy:
matrix:
node-version:
- 14.x
steps:
- uses: actions/checkout@v2
name: Run tests using Node.js ${{ matrix.node-version }}
- uses: actions/setup-node@v1
with:
node-version: "${{ matrix.node-version }}"
- run: npm install
- run: npm run build
env:
CI: true
86 changes: 43 additions & 43 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,47 +1,47 @@
name: Release on Tag
name: release-on-tag

on:
push:
# Sequence of patterns matched against refs/tags
tags:
- 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10
push:
# Sequence of patterns matched against refs/tags
tags:
- "v*" # Push events to matching v*, i.e. v1.0, v20.15.10

jobs:
build:
name: Create Release
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
# Add release to GitHub releases
- name: Create Release on GitHub
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref }}
release_name: Release ${{ github.ref }}
body: ${{ github.event.head_commit.message }}
draft: false
prerelease: false
# Setup .npmrc file to publish to npm
- name: Publish on NPM
uses: actions/setup-node@v1
with:
node-version: "14.x"
registry-url: "https://registry.npmjs.org"
- run: npm install
# Publish to NPM
- run: npm publish --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
# Setup .npmrc file to publish to GitHub Packages
- name: Publish on GitHub Packages
uses: actions/setup-node@v1
with:
registry-url: "https://npm.pkg.github.com"
# Publish to GitHub Packages
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
build:
name: Create Release
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
# Add release to GitHub releases
- name: Create Release on GitHub
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref }}
release_name: Release ${{ github.ref }}
body: ${{ github.event.head_commit.message }}
draft: false
prerelease: false
# Setup .npmrc file to publish to npm
- name: Publish on NPM
uses: actions/setup-node@v1
with:
node-version: "14.x"
registry-url: "https://registry.npmjs.org"
- run: npm install
# Publish to NPM
- run: npm publish --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
# Setup .npmrc file to publish to GitHub Packages
- name: Publish on GitHub Packages
uses: actions/setup-node@v1
with:
registry-url: "https://npm.pkg.github.com"
# Publish to GitHub Packages
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
10 changes: 3 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@
name: Run Tests on Push
name: test-on-commit
on:
push:
branches:
- master
- dev
- main
pull_request:
branches:
- master
- dev
- main
jobs:
test:
name: Run tests
runs-on: ubuntu-latest
strategy:
matrix:
node-version:
- 12.x
- 14.x
steps:
- uses: actions/checkout@v2
Expand All @@ -24,7 +21,6 @@ jobs:
with:
node-version: "${{ matrix.node-version }}"
- run: npm install
- run: npm run build
- run: npm test
env:
CI: true
1 change: 1 addition & 0 deletions .husky/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
_
6 changes: 6 additions & 0 deletions .huskyrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"hooks": {
"pre-commit": "npm start doc; git add ./docs; npm test",
"pre-push": "npm test"
}
}
15 changes: 11 additions & 4 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
{
"recommendations": [
"karyfoundation.nearley"
]
}
"recommendations": [
"streetsidesoftware.code-spell-checker",
"editorconfig.editorconfig",
"esbenp.prettier-vscode",
"dbaeumer.vscode-eslint",
"amatiasq.sort-imports",
"orta.vscode-jest",
"christian-kohler.path-intellisense",
"karyfoundation.nearley"
]
}
31 changes: 18 additions & 13 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,30 @@
"version": "0.2.0",
"configurations": [
{
"name": "Run in Development Mode",
"type": "node",
"request": "launch",
"name": "Debug",
"program": "${workspaceRoot}/dist/app.js",
"smartStep": true,
"outFiles": [
"../dist/**/*.js"
"args": ["${relativeFile}"],
"runtimeArgs": [
"--nolazy",
"-r",
"ts-node/register"
],
"protocol": "inspector",
"env": {
"NODE_ENV": "production"
}
"cwd": "${workspaceRoot}",
"protocol": "inspector"
},
{
"name": "vscode-jest-tests",
"type": "node",
"request": "attach",
"name": "Nodemon Debug",
"port": 9229,
"restart": true
"request": "launch",
"program": "${workspaceFolder}/node_modules/jest/bin/jest",
"args": [
"--runInBand"
],
"cwd": "${workspaceFolder}",
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen",
"disableOptimisticBPs": true
}
]
}
1 change: 0 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"files.exclude": {
"tsconfig.build.json": true,
},
"importSorter.generalConfiguration.sortOnBeforeSave": true,
"files.trimTrailingWhitespace": true,
"editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode"
Expand Down
26 changes: 0 additions & 26 deletions .vscode/tasks.json

This file was deleted.

Loading

0 comments on commit a3595b0

Please sign in to comment.