Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I install this package on laravel 8? #2

Closed
jonatansantana opened this issue Oct 18, 2020 · 7 comments
Closed

How do I install this package on laravel 8? #2

jonatansantana opened this issue Oct 18, 2020 · 7 comments
Assignees

Comments

@jonatansantana
Copy link

jonatansantana commented Oct 18, 2020

I have the need to use this package in version 8 of laravel, I tried to download it and make the necessary modifications for that, but I was unable to make it work. Can you help me with this?

@sn123 sn123 self-assigned this Oct 19, 2020
@sn123
Copy link
Member

sn123 commented Oct 19, 2020

Guess would make sense to add support for 6.x, 7.x and 8.x respectively.

@sn123
Copy link
Member

sn123 commented Oct 20, 2020

There's currently a blocker to add Laravel 8.x support, the reason being windows-azure SDK uses Guzzle 6.x whereas Laravel 8.x requires GuzzleHttp 7.x. See azure/azure-sdk-for-php/#1007 for more details.

Given that Windows Azure SDK for PHP is more or less abandoned, I really doubt it would be fixed over there. Our only viable option seems to be rewriting the SDK (at least the service bus parts) in PHP or use a fork which already supports Guzzle 7.x.

@sn123
Copy link
Member

sn123 commented Oct 20, 2020

Did some more digging and found a fork which ups the version numbers. The fork uses microsoft/azure-storage-common package which again relies on Guzzle 6.x, so basically a dead-end.

I think the way forward would be to fork windows-azure package, strip out all other stuff like Blobs and Media Server and have a dedicated azure-servicebus package. Finally use the azure-servicebus package over here.

@sn123 sn123 removed the blocked label Oct 21, 2020
@sn123
Copy link
Member

sn123 commented Oct 21, 2020

@jonatansantana We've updated the dev-master version of this package to support Laravel 8.x. This has been done by forking out Windows-Azure SDK and only keeping Service Bus code bits as mentioned above. Since 8.x support is currently experimental, the only way to include is by pointing to dev-master and using the git fork of the SDK. Below are the composer.json changes required:

"repositories": [{
        "type": "git",
        "url": "https://github.com/sn123/azure-sdk-for-php.git"
    }],
"require: {
        ...
        "goavega-software/laravel-azure-servicebus": "dev-master"
},

Rest everything should work the same as older laravels. Could you help us in testing the package and if all looks good, we'll go ahead and publish this along with the Forked SDK.

@jonatansantana
Copy link
Author

jonatansantana commented Oct 24, 2020 via email

@sn123
Copy link
Member

sn123 commented Oct 27, 2020

Hi, thanks for responding. I am very happy to have considered my email. And I think the idea of being able to contribute to the project is interesting. But at the moment I am very busy with other projects of the company I work for and in a way this makes my contribution a little difficult. Taking advantage of the opportunity, I would also like to inform you that, whenever I try to install your package in a docker container through the composer, I have several errors and the installation is not completed. I did a lot of research on this problem and didn't find much information to help me solve it. But without docker the installation takes place normally. Would you know how to inform what's going on? Attached I leave some images. [image: image.png] [image: image.png] Em qua., 21 de out. de 2020 às 07:43, sn123 [email protected] escreveu:

@jonatansantana https://github.com/jonatansantana We've updated the dev-master version of this package to support Laravel 8.x. This has been done by forking out Windows-Azure SDK and only keeping Service Bus code bits as mentioned above. Since 8.x support is currently experimental, the only way to include is by pointing to dev-master and using the git fork of the SDK. Below are the composer.json changes required: "repositories": [{ "type": "git", "url": "https://github.com/sn123/azure-sdk-for-php.git" }],"require: { ... "goavega-software/laravel-azure-servicebus": "dev-master"}, Rest everything should work the same as older laravels. Could you help us in testing the package and if all looks good, we'll go ahead and publish this along with the Forked SDK. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHY4RE535JIJBZVHO5MKZW3SL23MJANCNFSM4SVF2Y3A .

Can you add those error messages in the issue?

@jonatansantana
Copy link
Author

Analyzing the last error messages I sent, I noticed that the problem was with my docker image and not in the package. I managed to execute the package with your instructions in laravel 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants