Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/oauth2: properly support P-384 and P-521 keys #13317

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

rissson
Copy link
Member

@rissson rissson commented Feb 28, 2025

Details

Closes #11838


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson requested a review from a team as a code owner February 28, 2025 12:01
@rissson rissson self-assigned this Feb 28, 2025
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit ecc882d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67c1a583239bdc0007561b82

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit ecc882d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67c1a5832858ae0008f22c8f

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.71%. Comparing base (44238e6) to head (ecc882d).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/providers/oauth2/models.py 70.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13317      +/-   ##
==========================================
- Coverage   92.71%   92.71%   -0.01%     
==========================================
  Files         793      793              
  Lines       40268    40276       +8     
==========================================
+ Hits        37336    37342       +6     
- Misses       2932     2934       +2     
Flag Coverage Δ
e2e 48.07% <50.00%> (+<0.01%) ⬆️
integration 24.11% <27.77%> (+<0.01%) ⬆️
unit 90.43% <72.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ecc882d9a404a4a5b51696d3dc1b442fa2e36422
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ecc882d9a404a4a5b51696d3dc1b442fa2e36422

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson merged commit 7e7fc75 into main Feb 28, 2025
93 of 94 checks passed
@rissson rissson deleted the providers-oauth2-ecc-algs branch February 28, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES256 is used as "alg" in JWT generation regardless of actual ECC certificate curve
2 participants