Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return nullable on XivChatType.GetDetails #2143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return nullable on XivChatType.GetDetails #2143

wants to merge 1 commit into from

Conversation

Haselnussbomber
Copy link
Contributor

Some XivChatType do not have a XivChatTypeInfoAttribute on them, so XivChatType.GetDetails() should return a nullable.

@Haselnussbomber Haselnussbomber requested a review from a team as a code owner December 11, 2024 06:55
@Haselnussbomber
Copy link
Contributor Author

Haselnussbomber commented Dec 11, 2024 •
edited
Loading

Well, the Check API Compatibility workflow succeeded, so I guess that means it's not a breaking change?!
Renaming the PR then.

@Haselnussbomber Haselnussbomber changed the title [Api12] Return nullable on XivChatType.GetDetails Return nullable on XivChatType.GetDetails Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Haselnussbomber