(fix) CJS distribution for wallet-zilliqa #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
fixes #241
Background
What does this PR do?
It removes the static initialization of
chainId
, which causes ts to no longer generate invalid Javascript when exporting CJS modules.Testing
Attempt to import the npm-released version of
wallet-zilliqa
.Detailed testing results
I'm going to n/a this until requested to do so, because there's quite a lot of of it and this is quite a small PR - do yell if you want the full shebang.
Docs
no change required to project docs.
For plugins
Discord username
_naranek