Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) CJS distribution for wallet-zilliqa #242

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

rrw-zilliqa
Copy link
Contributor

Relates to:

fixes #241

Background

What does this PR do?

It removes the static initialization of chainId, which causes ts to no longer generate invalid Javascript when exporting CJS modules.

Testing

Attempt to import the npm-released version of wallet-zilliqa.

Detailed testing results

I'm going to n/a this until requested to do so, because there's quite a lot of of it and this is quite a small PR - do yell if you want the full shebang.

Method Prompt Screenshot Transaction Link
Action #1 Prompt to get it to take that action Screenshot of the result Transaction link
Action #2 Prompt to get it to take that action Screenshot of the result Transaction link

Docs

no change required to project docs.

For plugins

  • [X ] I have tested this change locally with key pair wallets
  • [ n/a] I have tested this change locally with hosted wallets (e.g. Crossmint Smart Wallets, etc.)
  • [ X] Package exists in the goat workspace file

Discord username

_naranek

…or appears to be broken, so initialize chainId in the constructor.
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 0229215

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@0xaguspunk 0xaguspunk merged commit 63bd28b into goat-sdk:main Jan 19, 2025
MahmoudMohajer pushed a commit to MahmoudMohajer/goat that referenced this pull request Feb 3, 2025
(fix) CJS distribution of objects with an initializer and a constructor appears to be broken, so initialize chainId in the constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wallet-zilliqa will not import in recent develop branch eliza
2 participants