Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
While playing around with the new example added for the Virtuals G.A.M.E framework in #207, I noticed that we're essentially embedding a new adapter inside the example.
Then it got me thinking that, in essence, every adapter performs the following steps:
What does this PR do?
I think it could be beneficial to have an adapter base class which has:
An example implementation would be what I added in this PR:
VirtualsGameAdapter
that extendsAdapterBase
await adapter.getAdaptedTools();
in the GAME example to get the list of converted toolsBenefits
Next steps
If this PR is approved, I can change existing adapters to leverage the new base class.
Testing
There should no change in functionality. I only refactored code related to adapter usage.
Discord username
toozol1