refactor: worker startup process #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 64.53% 64.53%
=======================================
Files 17 17
Lines 953 953
=======================================
Hits 615 615
Misses 223 223
Partials 115 115
|
golangcibot
reviewed
Mar 23, 2020
| ) | ||
|
|
||
| // helper function to setup the queue from the CLI arguments. | ||
| func setupQueue(c *cli.Context) (queue.Service, error) { | ||
| func setupQueue(q *queueSetup) (queue.Service, error) { |
There was a problem hiding this comment.
func setupQueue is unused (from unused)
| } | ||
| } | ||
|
|
||
| // helper function to setup the Kafka queue from the CLI arguments. | ||
| func setupKafka(c *cli.Context) (queue.Service, error) { | ||
| func setupKafka(q *queueSetup) (queue.Service, error) { |
There was a problem hiding this comment.
func setupKafka is unused (from unused)
| ) | ||
|
|
||
| // helper function to setup the queue from the CLI arguments. | ||
| func setupClient(c *cli.Context) (*vela.Client, error) { | ||
| log.Debug("Creating vela client from CLI configuration") | ||
| func setupClient(s *Server) (*vela.Client, error) { |
There was a problem hiding this comment.
func setupClient is unused (from unused)
| logrus.Tracef("Creating %s queue client from CLI configuration", constants.DriverKafka) | ||
| // return kafka.New(c.String("queue-config"), "vela") | ||
| return nil, fmt.Errorf("unsupported queue driver: %s", constants.DriverKafka) | ||
| } | ||
|
|
||
| // helper function to setup the Redis queue from the CLI arguments. | ||
| func setupRedis(c *cli.Context) (queue.Service, error) { | ||
| func setupRedis(q *queueSetup) (queue.Service, error) { |
There was a problem hiding this comment.
func setupRedis is unused (from unused)
cmd/vela-worker/start.go
Outdated
| package main | ||
|
|
||
| import ( | ||
| "github.com/sirupsen/logrus" |
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
Suggested change
| "github.com/sirupsen/logrus" |
| tomb := new(tomb.Tomb) | ||
|
|
||
| // spawn a tomb goroutine to manage the worker processes | ||
| tomb.Go(func() error { |
There was a problem hiding this comment.
unnecessary leading newline (from whitespace)
| } | ||
| }() | ||
|
|
||
| for { |
There was a problem hiding this comment.
S1000: should use for range instead of for { select {} } (from gosimple)
wass3r
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some of the linter errors but the linter is still failing for a couple checks 😢
The failed check for the
gosimplelinter (S1000error) I believe is a bug:dominikh/go-tools#503
The failed check for the
unusedlinter is a part of my ongoing refactor work but I'm trying to keep this PR a bit smaller.I vote we ignore the checks 👍