Fix unsigned int overflow

[shiyuhang0]

Description

close #1531

This pr https://github.com/go-sql-driver/mysql/pull/1452/files introduces the bug.

Checklist

• Code compiles correctly
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary
• Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

Summary by CodeRabbit

• Tests

  • Enhanced the TestNumbersToAny to support testing of an additional unsigned integer column in SQL queries.

• Refactor

  • Updated readRow method to improve handling of fieldTypeLong with consideration for column flags.

[coderabbitai]

Walkthrough

The recent updates involve modifications to both testing and functionality for handling SQL data types. In driver_test.go, a new unsigned integer column has been added to the test database schema, and the associated test code has been updated to handle this new column. In packets.go, the handling of long integer fields has been refined, with a new approach to parsing based on column flags, replacing a previously commented-out section.

Changes

Files	Summary of Changes
driver_test.go	The TestNumbersToAny function in the driver_test.go file has undergone several changes. The SQL table creation and insertion statements have been modified to include an additional column iu32 INT UNSIGNED. The query in the mustQuery function has been updated to include the new column, and the corresponding rows.Scan call has been adjusted to accommodate the new column. Additionally, assertions have been added to validate the value of the new iu32 column.
packets.go	The readRow method in the textRows type has been modified to handle the fieldTypeLong case differently. The commented-out code for fieldTypeLong has been replaced with a new conditional block that parses the input buffer differently based on the flags of the corresponding column. Additionally, it updates the parsing of integers from 32-bit to 64-bit, potentially affecting the range of supported values.

Assessment against linked issues

Objective	Addressed	Explanation
Empty result with max unsigned int value (Issue #1531)	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0004702 and 004ef0f.

Files selected for processing (2)

• driver_test.go (2 hunks)
• packets.go (1 hunks)

Additional comments: 4

driver_test.go (4)

• 388-403: The test TestNumbersToAny has been updated to include a new column iu32 INT UNSIGNED and corresponding assertions. Ensure that the test logic correctly handles the new unsigned integer column and that the assertions are valid and cover the expected behavior.

• 425-427: The assertion for the iu32 column checks if the value is equal to 4294967295. This is the maximum value for an unsigned 32-bit integer, which is correct. Ensure that the test case covers scenarios where iu32 might not be at its maximum value.

• 388-403: The test TestNumbersToAny includes a new column iu32 INT UNSIGNED in the SQL table creation and insertion statements. The query and the subsequent rows.Scan call within the mustQuery function have been adjusted to incorporate the new column. Additionally, new assertions have been added to validate the value of the new iu32 column. Ensure that the test logic correctly handles the new unsigned integer column and that the assertions are valid and cover the expected behavior.

• 425-427: The assertion for the iu32 column checks if the value is equal to 4294967295. This is the maximum value for an unsigned 32-bit integer, which is correct. Ensure that the test case covers scenarios where iu32 might not be at its maximum value.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 004ef0f and f37f416.

Files selected for processing (1)

• packets.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• packets.go

[shiyuhang0]

@methane PTAL and could you approve to run the GitHub action

[coveralls]

coverage: 82.171% (+0.03%) from 82.145%
when pulling 9479b80 on shiyuhang0:fix_unsigned_int
into 0004702 on go-sql-driver:master.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f37f416 and 9479b80.

Files selected for processing (1)

• packets.go (1 hunks)

Additional comments: 1

packets.go (1)

• 830-834: The change to parse integers as 64-bit values for fieldTypeLong seems to be consistent with the PR's objective to fix unsigned int overflow. However, it's important to ensure that this change does not introduce any regressions or issues with signed integers.

Please verify that all tests, including new ones for this change, pass and that there are no edge cases where this could cause a regression.

[okJiang]

It's cool~ @coderabbitai

[coderabbitai]

@okJiang Thank you! 😊