Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing 0 year. #1257

Merged
merged 5 commits into from
Nov 10, 2022
Merged

Fix parsing 0 year. #1257

merged 5 commits into from
Nov 10, 2022

Conversation

methane
Copy link
Member

@methane methane commented Aug 24, 2021 •
edited
Loading

Description

Fix #1252

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

shogo82148
shogo82148 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methane methane merged commit fa1e4ed into go-sql-driver:master Nov 10, 2022
@methane methane deleted the fix-1252 branch November 10, 2022 06:01
@methane methane mentioned this pull request Nov 10, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent time.Time value when changing interpolateParams
2 participants
@methane @shogo82148