Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mc.cleanup inside mysqlConn watchCancel #1032

Closed
wants to merge 1 commit into from
Closed

Move mc.cleanup inside mysqlConn watchCancel #1032

wants to merge 1 commit into from

Conversation

zjj
Copy link
Contributor

@zjj zjj commented Nov 19, 2019

ref issue: #1024 #1023

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane
Copy link
Member

methane commented Nov 19, 2019

Please explain why you think this change is needed.

@zjj
Copy link
Contributor Author

zjj commented Nov 19, 2019

Please explain why you think this change is needed.
so there's no need to add more cleanup calls to other XXContext, and keep the code pattern to be
same with original codes .
@methane

@methane
Copy link
Member

methane commented Nov 19, 2019

Other XxxContext APIs don't need mc.cleanup().

For example, if QueryContext is called with closed context, there is no need to close the connection.

@methane methane closed this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants