Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fuzz.go #1445

Closed
dolmen opened this issue Jun 2, 2023 · 0 comments · Fixed by #1498
Closed

Remove fuzz.go #1445

dolmen opened this issue Jun 2, 2023 · 0 comments · Fixed by #1498

Comments

@dolmen
Copy link
Contributor

dolmen commented Jun 2, 2023

fuzz.go added in #1097 is now obsolete:

  • it was written for go-fuzz but should be at least ported to the Go 1.18 fuzzing framework
  • error handling/reporting is almost inexistant
  • running the fuzzer is dangerous as it might connect to random machines on the Internet because the fuzzing process might generate those IP/port (so just porting would be a bad idea)
  • it fuzzes DSN which is now redundant with fuzzing I have just proposed in Add fuzz test for ParseDSN / FormatDSN roundtrip #1444
  • the fuzzer was written for oss-fuzz, but I haven't found the matching project in https://github.com/google/oss-fuzz/tree/master/projects
  • according to oss-fuzz documentation the project should have a cifuzz.yml, but we haven't one

So if we want to participate to oss-fuzz a different fuzzer should be implemented (#1444 is a good start) and the project must be registered.

As is fuzz.go is just useless and can be deleted.
@dolmen dolmen changed the title Remove obsolete/dangerous/useless fuzz.go Remove fuzz.go Jun 2, 2023
@dolmen dolmen mentioned this issue Oct 17, 2023
Merged
1 task
dolmen added a commit to dolmen/mysql that referenced this issue Oct 17, 2023
@dolmen
Remove obsolete fuzz.go
8f8d75c 
fuzz.go (added in go-sql-driver#1097) uses gofuzz. But in go-sql-driver#1444 I've added a better
fuzzer that uses Go builtin fuzzing.

Closes go-sql-driver#1445.
dolmen added a commit to dolmen/mysql that referenced this issue Oct 17, 2023
@dolmen
Remove obsolete fuzz.go
9de133b 
fuzz.go (added in go-sql-driver#1097) uses gofuzz. But in go-sql-driver#1444 I've added a better
fuzzer that uses Go builtin fuzzing.

Closes go-sql-driver#1445.
methane pushed a commit that referenced this issue Oct 19, 2023
@dolmen
Remove obsolete fuzz.go (#1498)
1e6b8d7 
fuzz.go (added in #1097) uses gofuzz.
But #1444 added a better fuzzer that uses Go builtin fuzzing.

Closes #1445.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove obsolete fuzz.go #1445 dolmen/mysql
1 participant
@dolmen