-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multipart file upload streaming #309 #879
Merged
Merged
+628
−582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 98.15% 98.35% +0.20%
==========================================
Files 14 15 +1
Lines 2329 2431 +102
==========================================
+ Hits 2286 2391 +105
+ Misses 23 21 -2
+ Partials 20 19 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Oct 4, 2024
major0
added a commit
to major0/go-proton-api
that referenced
this pull request
Jan 16, 2025
reverts 17c9b5b Stop using a custom version of go-resty. The original reason for forking resty has since been fixed. See: - go-resty/resty#334 - go-resty/resty#879
major0
added a commit
to major0/go-proton-api
that referenced
this pull request
Jan 16, 2025
Stop using a custom version of go-resty. The original reason for forking resty has since been fixed. See: - go-resty/resty#334 - go-resty/resty#879
major0
added a commit
to major0/go-proton-api
that referenced
this pull request
Jan 16, 2025
Stop using a custom version of go-resty. The original reason for forking resty has since been fixed. See: - go-resty/resty#334 - go-resty/resty#879
major0
added a commit
to major0/go-proton-api
that referenced
this pull request
Jan 16, 2025
Stop using a custom version of go-resty. The original reason for forking resty has since been fixed. See: - go-resty/resty#334 - go-resty/resty#879
major0
added a commit
to major0/go-proton-api
that referenced
this pull request
Jan 27, 2025
Stop using a custom version of go-resty. The original reason for forking resty has since been fixed. See: - go-resty/resty#334 - go-resty/resty#879
major0
added a commit
to major0/go-proton-api
that referenced
this pull request
Jan 27, 2025
reverts 17c9b5b Stop using a custom version of go-resty. The original reason for forking resty has since been fixed. See: - go-resty/resty#334 - go-resty/resty#879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the long-awaited feature of multipart file upload streaming in Resty. There are two behavior -
io. Reader
is detected in the MultipartField; Resty, by default, will stream the content in the request bodyThis PR opens the way for the next feature, i.e., multipart live upload progress callback.
closes #309
closes #495
closes #576
closes #650