Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make default retry not on middlewares errors #333

Merged
merged 1 commit into from
May 11, 2020
Merged

make default retry not on middlewares errors #333

merged 1 commit into from
May 11, 2020

Conversation

lrita
Copy link
Contributor

@lrita lrita commented Apr 29, 2020

This patch make default retry not on middlewares errors, which will make the retry action more sense and return error faster.

which will make the retry action more sense and
return error faster
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #333 into master will increase coverage by 0.04%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   95.64%   95.69%   +0.04%     
==========================================
  Files           9        9              
  Lines        1195     1207      +12     
==========================================
+ Hits         1143     1155      +12     
  Misses         30       30              
  Partials       22       22              
Impacted Files Coverage Δ
client.go 96.87% <60.00%> (ø)
request.go 100.00% <100.00%> (ø)
retry.go 97.36% <100.00%> (+0.03%) ⬆️
util.go 90.85% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad527eb...4c7edad. Read the comment docs.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lrita Thanks for the PR and enhancing retry error handling.

@jeevatkm jeevatkm merged commit 49899fe into go-resty:master May 11, 2020
@jeevatkm jeevatkm added this to the v2.3.0 Milestone milestone May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants