Allow named structs to be embedded #303
Conversation
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 35 35
Lines 2879 2884 +5
=========================================
+ Hits 2879 2884 +5
Continue to review full report at Codecov.
|
| @@ -357,6 +357,21 @@ func fieldName(sf reflect.StructField) (string, bool) { | |||
| return snaker.CamelToSnake(sf.Name), false | |||
| } | |||
|
|
|||
| func isEmbedded(sf reflect.StructField) bool { | |||
| // anonymous structs are always embedded | |||
There was a problem hiding this comment.
Is this still true to provide backwards compatibility?
There was a problem hiding this comment.
anonymous struct is basically an embedded struct, so I think no problem
| @@ -357,6 +357,21 @@ func fieldName(sf reflect.StructField) (string, bool) { | |||
| return snaker.CamelToSnake(sf.Name), false | |||
| } | |||
|
|
|||
| func isEmbedded(sf reflect.StructField) bool { | |||
| // anonymous structs are always embedded | |||
There was a problem hiding this comment.
anonymous struct is basically an embedded struct, so I think no problem
document_meta.go
Outdated
| } | ||
| // search for embedded tag | ||
| tags := strings.Split(sf.Tag.Get("db"), ",") | ||
| for i, tag := range tags { |
There was a problem hiding this comment.
other codes uses strings.HasSuffix (example)
I think the advantage of using HasSuffix is it doesn't need intermediary slice
but this is fine as well because it'll be cached anyway
There was a problem hiding this comment.
If HasSuffix is ok, let's use it.
Just feels a bit weird as this means that we can't have more than one struct tag (except for the name) 🤔
Follow up on #262 that fixes #277 and #296