Get more type information from file parser #246
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,19 @@ | |||
| return s.PKFieldIndex >= 0 | |||
| } | |||
|
|
|||
| func (s *StructInfo) IsIntPK() bool { | |||
There was a problem hiding this comment.
[Optional linters] reported by reviewdog 🐶
exported method StructInfo.IsIntPK should have comment or be unexported (golint)
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 68.08% 67.68% -0.40%
==========================================
Files 19 19
Lines 1720 1730 +10
==========================================
Hits 1171 1171
- Misses 491 501 +10
Partials 58 58
Continue to review full report at Codecov.
|
|
When will this go into release? |
| @@ -121,6 +121,19 @@ | |||
| return s.PKFieldIndex >= 0 | |||
| } | |||
|
|
|||
| func (s *StructInfo) IsIntPK() bool { | |||
There was a problem hiding this comment.
🚫 [Optional linters] reported by reviewdog 🐶
exported method StructInfo.IsIntPK should have comment or be unexported (golint)
AlekSi
force-pushed
the
make-vet-happy
branch
from
a98682c to
821dd24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.