Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piv: use PINPolicy to determine PINPrompt strategy #50

Merged
merged 1 commit into from
Apr 27, 2020
Merged

piv: use PINPolicy to determine PINPrompt strategy #50

merged 1 commit into from
Apr 27, 2020

Conversation

ericchiang
Copy link
Collaborator

Fixes #49

@ericchiang ericchiang mentioned this pull request Apr 26, 2020
Closed
@ericchiang
Copy link
Collaborator Author

Tests:

% go test -v -run=TestPINPrompt . --wipe-yubikey
=== RUN   TestPINPrompt
=== RUN   TestPINPrompt/Never
=== RUN   TestPINPrompt/Once
=== RUN   TestPINPrompt/Always
--- PASS: TestPINPrompt (1.39s)
    --- PASS: TestPINPrompt/Never (0.46s)
    --- PASS: TestPINPrompt/Once (0.46s)
    --- PASS: TestPINPrompt/Always (0.47s)
PASS
ok      github.com/go-piv/piv-go/piv    1.641s

@ericchiang ericchiang merged commit 6bdd3b3 into master Apr 27, 2020
@ericchiang ericchiang deleted the pin-policy-always branch April 27, 2020 01:26
This was referenced May 10, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PIN is not obtained for second signature with "always" PIN policy
1 participant
@ericchiang