Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure on arm FreeBSD #104

Closed
clausecker opened this issue Jul 22, 2022 · 2 comments · Fixed by #107
Closed

Build failure on arm FreeBSD #104

clausecker opened this issue Jul 22, 2022 · 2 comments · Fixed by #107

Comments

@clausecker
Copy link
Contributor

The build fails as follows on arm FreeBSD:

# github.com/go-piv/piv-go/piv
vendor/github.com/go-piv/piv-go/piv/pcsc_freebsd.go:29:15: 0x8010002E (untyped int constant 2148532270) overflows int32
golang.org/x/crypto/ssh/agent
*** Error code 2

Please check and possible add a cast to make the number negative.
@ericchiang
Copy link
Collaborator

I don't have access to a FreeBSD environment so I'm not able to test any changes. If someone who does have one wants to send a PR and run the tests locally, I'm happy to review

@clausecker
Copy link
Contributor Author

Sure, let me prepare something for you.

@clausecker clausecker mentioned this issue Aug 4, 2022
Merged
ericchiang pushed a commit that referenced this issue Aug 4, 2022
@clausecker @ericchiang
piv/pcsc_freebsd.go: fix build on 32 bit FreeBSD
1902689 
Fixes	#104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

piv/pcsc_freebsd.go: fix build on 32 bit FreeBSD
2 participants
@clausecker @ericchiang