add macos testing #111
Merged
add macos testing #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syndbg
approved these changes
Feb 14, 2020
|
@syndbg for right now, I think the WIP does. I don't want to break your tests, which i currently do. let me see if i can get the |
stephengroat
force-pushed
the
patch-1
branch
from
19dad19 to
790b28b
Compare
|
@syndbg looks good to go now. not the cleanest, but it works let me know if you want me to squash up |
|
A bit late to the PR, but great work! Thank you very much for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
macOStestingWIP: need to fix
assert_output_containsfunction, currently doesn't seem to be failing when it shouldthis https://github.com/syndbg/goenv/pull/111/files#diff-cab00a4bf27292f45f67ea71451598c7R666 should fail but doesn't