Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canal,dump: Improve logging #953

Merged
merged 1 commit into from
Nov 23, 2024
Merged

canal,dump: Improve logging #953

merged 1 commit into from
Nov 23, 2024

Conversation

dveeden
Copy link
Collaborator

@dveeden dveeden commented Nov 22, 2024

  1. Add logging documentation to README.md
  2. Make the logger for dumper configurable
  3. Let canal pass the logger to dumper

Closes #848

@lance6716 lance6716 merged commit 611e959 into go-mysql-org:master Nov 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@atercattus atercattus Awaiting requested review from atercattus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how to remove log output
2 participants
@dveeden @lance6716