Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (*RowsEvent).handleUnsigned() panic #856

Merged
merged 3 commits into from
Apr 11, 2024
Merged

fix: (*RowsEvent).handleUnsigned() panic #856

merged 3 commits into from
Apr 11, 2024

Conversation

equnchen
Copy link
Contributor

canal_panic

@lance6716
Copy link
Collaborator

Hi, can you add an unit test for it?

@equnchen
Copy link
Contributor Author

Hi, can you add an unit test for it?

Sorry, I'm very busy at work recently. How about we fix this obvious bug first?

@lance6716
Copy link
Collaborator

we have other fix PR like #495 #689 #792 . In order to be fair to them I also request the unit test for this PR

@equnchen
Copy link
Contributor Author

Hi, can you add an unit test for it?

done

lance6716
lance6716 reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm. Thank you

canal/rows_test.go Outdated Show resolved Hide resolved
@lance6716 lance6716 merged commit f0df38a into go-mysql-org:master Apr 11, 2024
13 checks passed
This was referenced Apr 12, 2024
Closed
Closed
@equnchen equnchen deleted the fix/rows_event_unsigned_panic branch April 12, 2024 14:12
@lance6716 lance6716 mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@equnchen @lance6716