Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed use of deprecated ioutil #724

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Conversation

skoef
Copy link
Contributor

@skoef skoef commented Aug 17, 2022

The package io/ioutil has been deprecated since Go 1.16

@skoef
Copy link
Contributor Author

skoef commented Aug 17, 2022

It seems CI fails because we're still supporting Go 1.15, is that really still necessary?

@lance6716
Copy link
Collaborator

GitHub "Used by" lists other projects that using this library. I checked about 20 active projects, only https://github.com/alibaba/ilogtail uses golang version < 1.16. No big deal. I agree on this PR.

What do you think? @atercattus

and seems golangci is still complaining about some problems, can you also fix them? @skoef

@skoef
Copy link
Contributor Author

skoef commented Aug 17, 2022

While not being super-descriptive, the File is not goimport-ed actually meant "I don't like the whitespace in your comments!". It is fixed now.

@lance6716
Copy link
Collaborator

I have changed the "required CI" for master branch, you can push again to trigger the new rules. Removing v1.15 from the test matrix is a good commit 😄 @skoef

go: [ 1.18, 1.17, 1.16, 1.15 ]

Signed-off-by: lance6716 <[email protected]>
@lance6716 lance6716 merged commit 36c03f5 into go-mysql-org:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants