Read auth_data_len from InitialHandshake packet instead of hard code #640
+20
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, when syncer receive an EOF Packet, it's means that user set 'BINLOG_DUMP_NON_BLOCK' flag in COM_BINLOG_DUMP command and there is no more binlog event now. master will send this Packet instead of blocking |
lance6716
reviewed
Nov 15, 2021
client/auth.go
Outdated
| // auth_data is end with 0x00, max data length is 13 + 8 = 21 | ||
| // ref to https://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::Handshake | ||
| maxAuthDataLen := 21 | ||
| if c.capability&CLIENT_PLUGIN_AUTH != 0 && int(data[pos]) < maxAuthDataLen { |
There was a problem hiding this comment.
if int(data[pos]) is 9, resetOfAuthDataEndPos will equals pos. But as stated $len=MAX(13, length of auth-plugin-data - 8) in https://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::Handshake, resetOfAuthDataEndPos should be pos + 13 - 1?
There was a problem hiding this comment.
sorry, it's my fault. it's min_auth_data_len is 21, not max_data_len.
There was a problem hiding this comment.
and this pr is a little bit old, need to be updated :-)
lance6716
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
When Fake Slave receive initialHandshake packet from Master, it'll decodes this packet. The current implementation uses hard-coded methods to obtain auth_data_part_2.
Change
But actually we can get auth_data_len from initHandshake packet. We can use the same method to get auth_plugin_name(ref to MySQL Doc)
Test
I've tested this change with my local MySQL, it's ok