expose capability and charset of connections to server #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored readFirstPacket for improved testability
lance6716
approved these changes
Jun 16, 2021
|
Awesome, thanks for your swift action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project of mine I need to be able to read the capabilities and default charset of a client connecting to my server. This PR exposes those 2 properties. Charset perhaps used to be decoded before into a type called
CollationIdbut this doesn't exist (anymore) and I'm perfectly fine with the collation ID as an uint8.I also took the liberty to refactor
readFirstPacketa bit so it is easier to test its behaviour