Fix comparison bug in MariadbGTIDSet.Equal() function (#853)

go-mysql-org · Mar 14, 2024 · 2199dfb · 2199dfb
1 parent 034c7ab
commit 2199dfb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/mysql/mariadb_gtid.go b/mysql/mariadb_gtid.go
@@ -217,6 +217,9 @@ func (s *MariadbGTIDSet) Equal(o GTIDSet) bool {
 		if !ok {
 			return false
 		}
+		if len(serverSet) != len(set) {
+			return false
+		}
 		for serverID, gtid := range set {
 			if o, ok := serverSet[serverID]; !ok {
 				return false

diff --git a/mysql/mariadb_gtid_test.go b/mysql/mariadb_gtid_test.go
@@ -181,6 +181,7 @@ func TestMariaDBGTIDSetEqual(t *testing.T) {
 		{"1-1-1,2-2-2", "1-1-1", false},
 		{"1-1-1,2-2-2", "1-1-1,2-2-2", true},
 		{"1-1-1,2-2-2", "1-1-1,2-2-3", false},
+		{"0-1-1,0-2-2", "0-2-2", false},
 	}
 
 	for _, cs := range cases {