New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid interrupt inflight requests after a new socket connect failed #481

Open

carter2000 wants to merge 1 commit into go-mgo:v2-unstable from carter2000:closeidle_v2

carter2000 commented Aug 17, 2017

If mongoServer fail to dial server, it will close all sockets that are alive, whether they're currently use or not.
There are two cons:

Inflight requests will be interrupt rudely.
All sockets closed at the same time, and likely to dial server at the same time. Any occasional fail in the massive dial requests (high concurrency scenario) will make all sockets closed again, and repeat...(It happened in our production environment)

So I think sockets currently in use should closed after idle.


          Avoid interrupt inflight requests after a new socket connect failed

8d58d60

Author

carter2000 commented Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet