Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor
ParseDN
function to fix resource usage and invalid parsings (fixes #487) #497feat: Refactor
ParseDN
function to fix resource usage and invalid parsings (fixes #487) #497Changes from 1 commit
a3e5bcd
3600fa8
e52f19b
5c0493f
File filter
Filter by extension
Conversations
Jump to
ParseDN
function to fix resource usage and invalid p…There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpuschma @johnweldon
Great to see you are improving this function!
There is one small issue with this approach that I also figured out too late:
asn1.Unmarshal(
only supports DER parsing, while thegithub.aaakk.us.kg/go-asn1-ber/asn1-ber
library supports BER parsing too.This means that parseDN deviates from the RFC, possibly resulting in unexpected limitations for the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into this and also extend the test cases. We didn't catch on that either. Thank you for pointing this out, @inteon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have some extra testcases that might be useful. Will create a PR soon.