-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic ldif reader #49
Closed
Closed
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
626a90b
add basic ldif reader
vetinari 5b2dc4d
Rework
vetinari 33174f5
moved
vetinari 47139c1
marshal ldif.LDIF{}s
vetinari 553040a
FoldWidth for marshalling
vetinari 9b058ac
export struct values
vetinari 039842e
add marshalling of change requests
vetinari b28402d
allow no line folding with FoldWidth < 0
vetinari f5b1f54
doc update
vetinari 80a4fdf
fixes, add EntriesAsLDIF()/ChangesAsLDIF()
vetinari 88b0c4c
tests for marshalling changes + fixes for those
vetinari 9aeb445
Merge branch 'master' of github.com:go-ldap/ldap into ldif-reader
vetinari f76f90f
clenup for golint / govet
vetinari bdac54f
update, add Parse(), Apply()
vetinari 94b60a2
fix error where multiple blank lines cause panic while parsing
vetinari 8232180
enforce optional "version: " only on first entry
vetinari 80c0aa1
Merge branch 'master' into ldif-reader
vetinari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
package ldif_test | ||
|
||
import ( | ||
"gopkg.in/ldap.v2/ldif" | ||
"io/ioutil" | ||
"os" | ||
"testing" | ||
|
||
"gopkg.in/ldap.v2/ldif" | ||
) | ||
|
||
var ldifRFC2849Example = `version: 1 | ||
|
@@ -181,4 +182,28 @@ func TestLDIFURL(t *testing.T) { | |
} | ||
} | ||
|
||
// vim: ts=4 sw=4 noexpandtab nolist | ||
var ldifMultiBlankLines = `# Organization Units | ||
dn: ou=users,dc=example,dc=com | ||
objectClass: organizationalUnit | ||
objectClass: top | ||
ou: users | ||
|
||
|
||
# searches for above empty line for dn but fails and errors out in this PR | ||
# Even though this is a valid LDIF file for ldapadd | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looked a little familiar haha, these two comments aren't necessary anymore I don't think. Thanks for the fix! |
||
dn: ou=groups,dc=example,dc=com | ||
objectClass: organizationalUnit | ||
objectClass: top | ||
ou: groups | ||
` | ||
|
||
func TestLDIFMultiBlankLines(t *testing.T) { | ||
l, err := ldif.Parse(ldifMultiBlankLines) | ||
if err != nil { | ||
t.Errorf("Failed to parse LDIF: %s", err) | ||
} | ||
ou := l.Entries[1].Entry.GetAttributeValue("ou") | ||
if ou != "groups" { | ||
t.Errorf("wrong ou in second entry: %s", ou) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto