-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EqualFold function on AttributeTypeAndValue. #307
Add EqualFold function on AttributeTypeAndValue. #307
Conversation
4d4c7a2
to
977775c
Compare
61f2bcc
to
6841802
Compare
@liggitt @johnweldon We already have a search that is case sensitive (since v3) and would be beneficial if we can also have RND compare functions as case insensitive. |
Hi @zerodayz, please apply the changes to v3/ folder's relevant files and rebase so we can consider merging. Ill review this weekend to get a new release out this week then. Thanks, |
6841802
to
7a1b50d
Compare
Hi @stefanmcshane, applied changes to v3 directory. Thank you Stefan |
Hi @zerodayz, Thanks for your help and contribution, |
Since v3 ldap we have case insensitive search in parallel to a case sensitive search: I would like to propose to add an EqualFold function in parallel to Equal function in dn.go on AttributeTypeAndValue. So we can not only search in case sensitive but also compare RDNs.
7a1b50d
to
acf2a83
Compare
@stefanmcshane I have added those back into root. |
Merged this - If you get a chance to write some supporting unit tests, those would be greatly appreciated. Ill cut a new release with this and other changes this weekend. |
Since v3 ldap we have case insensitive search in parallel to a case sensitive search:
#111
I would like to propose to add an EqualFold function in parallel to Equal function in dn.go on AttributeTypeAndValue.
So we can not only search in case sensitive but also compare RDNs.