Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: export some conditional functions #159

Merged
merged 2 commits into from
Jun 4, 2022
Merged

mysql: export some conditional functions #159

merged 2 commits into from
Jun 4, 2022

Conversation

kblomster
Copy link
Contributor

COALESCE, NULLIF, GREATEST and LEAST already existed and were available in the postgres dialect, but not in MySQL. GREATEST and LEAST behave differently with nulls than they do in Postgres, but I don't think that matters to Jet.

Fixes #158.

go-jet and others added 2 commits May 17, 2022 11:45
COALESCE, NULLIF, GREATEST and LEAST already existed
and were available in the postgres dialect, but not in MySQL.
@codecov-commenter
Copy link

Codecov Report

Merging #159 (792f89a) into master (38b6caf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files         115      115           
  Lines        6846     6846           
=======================================
  Hits         6340     6340           
  Misses        405      405           
  Partials      101      101           
Impacted Files Coverage Δ
mysql/functions.go 92.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b6caf...792f89a. Read the comment docs.

@go-jet go-jet changed the base branch from master to develop June 4, 2022 10:09
@go-jet
Copy link
Owner

go-jet commented Jun 4, 2022

Thanks, looks good.

@go-jet go-jet merged commit 5a0d052 into go-jet:develop Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COALESCE missing in MySQL
3 participants