Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up fetchData #601

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Speed up fetchData #601

merged 5 commits into from
Jul 12, 2024

Conversation

deniszh
Copy link
Member

@deniszh deniszh commented Jul 11, 2024 •
edited
Loading

During investigation of slow queries on server with big amount of files I found out that main culprit was on fetchData - it's doing data fetch serially, which is slow on hundreds and thousands of files. Main bottleneck should be disk, but we're doing some realtime merging with cache. We can speed up fetchData with goroutines, with sane cap (2 x GOMAXPROCS).
Also contains queryCache to expireCache struct renaming, as TODO asked.

@deniszh deniszh marked this pull request as ready for review July 12, 2024 09:50
@deniszh deniszh merged commit 05ed84c into go-graphite:master Jul 12, 2024
9 checks passed
@deniszh deniszh deleted the DZ-findWork branch July 12, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadolsky emadolsky emadolsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deniszh @emadolsky