Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ParseWithSchemaTable method and improve test. #4789

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Refactor ParseWithSchemaTable method and improve test. #4789

merged 3 commits into from
Oct 25, 2021

Conversation

huacnlee
Copy link
Collaborator

@huacnlee huacnlee commented Oct 19, 2021 •
edited
Loading

For improve #4773

@huacnlee huacnlee force-pushed the fix-4773-things branch 3 times, most recently from bd4940a to 4d39936 Compare October 20, 2021 12:46
@huacnlee huacnlee force-pushed the fix-4773-things branch 2 times, most recently from e8fc6c9 to d00c818 Compare October 20, 2021 14:20
daheige
daheige approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@daheige daheige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinzhu jinzhu merged commit d321190 into master Oct 25, 2021
@huacnlee huacnlee deleted the fix-4773-things branch October 25, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daheige daheige daheige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huacnlee @daheige @jinzhu