Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3: Update glfw to v3.3.8 #361

Merged
merged 3 commits into from
Aug 6, 2022
Merged

v3.3: Update glfw to v3.3.8 #361

merged 3 commits into from
Aug 6, 2022

Conversation

Jacalz
Copy link
Collaborator

@Jacalz Jacalz commented Jul 23, 2022

This PR updates the version of glfw to 3.3.8 for the v3.3 module. The new release includes a bunch of new bug fixes: https://www.glfw.org/changelog.

@dmitshur
Copy link
Member

dmitshur commented Jul 24, 2022

Thanks. One question so far, the rest looks good.

It looks like the wayland files were previously in v3.3/glfw/glfw/src directory, which this PR updates, but it also adds similar files in the v3.3 directory. Is that working as expected, or should we only have one set of those files in one directory?

@dmitshur
Copy link
Member

Friendly ping @Jacalz, see question above when you get a chance. Thanks.

@Jacalz
Copy link
Collaborator Author

Jacalz commented Jul 31, 2022

Sorry. I forgot to answer and now I’ve been on a short vacation. I think it might just have been a mistake on my end but will have a look in a few days time.

@dmitshur
Copy link
Member

No problem, and thanks!

@Jacalz
Copy link
Collaborator Author

Jacalz commented Aug 2, 2022

I have removed the files now. I don't know why they were there in the first place bu I suppose that they might have been some leftover from #358 in my local Git tree.

Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@dmitshur dmitshur merged commit 55e207c into go-gl:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants