Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login/oauth/userinfo endpoint [draft] #8962

Closed
wants to merge 7 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 13, 2019

draft for #8534

func GetUserinfoOauth(ctx *context.Context) {
user := convert.ToUser(ctx.User, ctx.IsSigned, ctx.User != nil)
app_url := setting.AppURL
if setting.AppSubURL != "" {
Copy link
Member Author

@6543 6543 Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there exist a better way to get the Profile-URL just tell me ...

Copy link
Member

@adelowo adelowo Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user.HomeLink() or user. HTMLURL()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adelowo nice to know! thx ... but it looks like @lafriks is working on this already ... :=

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 13, 2019
@lafriks
Copy link
Member

lafriks commented Nov 13, 2019

It won't work quite like that. userinfo endpoint is called s2s so there won't be signed in user, so it has to use JWT access token. I actually also have already started to work on this :]

@6543
Copy link
Member Author

6543 commented Nov 13, 2019

@lafriks ok ... what is your PR Nr.?

PS: feel free to use this code / close it ... (it's only a draft)

@6543
Copy link
Member Author

6543 commented Dec 13, 2019

@lafriks whats the current state of yours?

@lunny lunny added the type/enhancement An improvement of existing functionality label Dec 14, 2019
@stale
Copy link

stale bot commented Feb 11, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 11, 2020
@6543
Copy link
Member Author

6543 commented Feb 11, 2020

@lafriks " I actually also have already started to work on this :]" ... can I close mine?

@stale stale bot removed the issue/stale label Feb 12, 2020
@lafriks
Copy link
Member

lafriks commented Feb 12, 2020

I will close when I submit mine :)

@sikmir
Copy link

sikmir commented Apr 3, 2020

@lafriks is there any news on your PR?

routers/user/oauth.go Outdated Show resolved Hide resolved
routers/user/oauth.go Outdated Show resolved Hide resolved
routers/user/oauth.go Outdated Show resolved Hide resolved
routers/user/oauth.go Outdated Show resolved Hide resolved
routers/user/oauth.go Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jun 2, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Jun 2, 2020
@6543 6543 closed this Jun 3, 2020
@6543 6543 deleted the feature_oauth_userinfo branch June 3, 2020 10:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants