-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
login/oauth/userinfo endpoint [draft] #8962
Conversation
routers/user/oauth.go
Outdated
func GetUserinfoOauth(ctx *context.Context) { | ||
user := convert.ToUser(ctx.User, ctx.IsSigned, ctx.User != nil) | ||
app_url := setting.AppURL | ||
if setting.AppSubURL != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there exist a better way to get the Profile-URL just tell me ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user.HomeLink()
or user. HTMLURL()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't work quite like that. userinfo endpoint is called s2s so there won't be signed in user, so it has to use JWT access token. I actually also have already started to work on this :] |
@lafriks ok ... what is your PR Nr.? PS: feel free to use this code / close it ... (it's only a draft) |
@lafriks whats the current state of yours? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
@lafriks " I actually also have already started to work on this :]" ... can I close mine? |
I will close when I submit mine :) |
@lafriks is there any news on your PR? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
draft for #8534