Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to merge if file path contains " or \ (#8629) #8771

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Allow to merge if file path contains " or \ (#8629) #8771

merged 1 commit into from
Nov 1, 2019

Commits on Nov 1, 2019

  1. Allow to merge if file path contains " or \ (go-gitea#8629) 

    * if a filename in a repository contains " or \ the owner can't merge pull request with this files
because "git diff-tree" adds double quotes to that filepath
example: filepath is ab"cd but "git diff-tree" returns "ab\"cd"

now, when the owner click "Merge Pull Request" button the server returns 500
this commit fix it

Signed-off-by: Ilya Pavlov <[email protected]>

* add -z option to getDiffTree
escape spec symbols for sparse-checkout

Signed-off-by: Ilya Pavlov <[email protected]>

* go fmt

Signed-off-by: Ilya Pavlov <[email protected]>

* typo

Signed-off-by: Ilya Pavlov <[email protected]>

* escape '\'
escape all spaces and '!'

* use regexp.ReplaceAllString()

Signed-off-by: Ilya Pavlov <[email protected]>

* strings.ReplaceAll was added in go 1.12

Signed-off-by: Ilya Pavlov <[email protected]>

* add '\' to regexp.MustCompile

Signed-off-by: Ilya Pavlov <[email protected]>
    @Ilya33 @zeripath
    Ilya33 authored and zeripath committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    38f288e View commit details
    Browse the repository at this point in the history