Fix illogical setting defaults re. SSH_PORT and SSH_LISTEN_PORT

[leonardw]

Fix issue whereby setting SSH_PORT, for the purpose of constructing a superficial git-clone URL, would implicitly also set SSH_LISTEN_PORT that the SSH service binds to, if the latter is not explicitly configured.

Manifestation

SSH_PORT=2222
Would cause Gitea to also modify SSH_LISTEN_PORT and start up SSH on port 2222.

Work around would be to simultaneously force service port binding back to 22:
SSH_PORT=2222
SSH_LISTEN_PORT=22

So, the actual service binding SSH_LISTEN_PORT is being defaulted to SSH_PORT that's used for 'external decoration.' It should really be the other way around.

Rationale

Documentation states that:

• SSH_LISTEN_PORT: Port for the built-in SSH server.
• SSH_PORT: SSH port displayed in clone URL

Therefore, it stands to reason to expect that:

• SSH_LISTEN_PORT should default to 22, unless explicitly overriden, and with no other implicit defaults.
• SSH_PORT should be allowed to be freely set to any value as seen fit, depending on infrastructure/platform (be it Docker or otherwise) without implications on underlying service configuration. Though, it is sensible to default to the SSH_LISTEN_PORT above.

Additional Info

Documentation files are updated accordingly.

This may be considered a corrective fix to prior merged PR issues #8453 and #8477.

[guillep2k]

I think this should probably be labeled as kind/breaking.

[zeripath]

I disagree that this is illogical as it currently stands.

[zeripath]

To be clearer:

Rather than break existing instances we should just update the documentation to make it clear which inherits from which. Some may prefer it one way or the other but it's just a choice, one that's already been made. (It may be inconsistent but it's been made already.)

What's the benefit of breaking existing instances here? If this was part of a concerted effort to rationalize config names and make the configuration of http services clearer I'd agree but as a standalone pr just changing the order of inheritance potentially causing everyone who just uses SSH_PORT to have to update their config it seems unnecessary.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

[stale]

This pull request has been automatically closed because of inactivity. You can re-open it if needed.